Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer callbacks #60

Open
dancheskus opened this issue Nov 3, 2020 · 0 comments
Open

Timer callbacks #60

dancheskus opened this issue Nov 3, 2020 · 0 comments

Comments

@dancheskus
Copy link

dancheskus commented Nov 3, 2020

onTimeUpdate wrong triggering time

onTimeUpdate function is called on component mount. I think it should be called ONLY when timer status is 'RUNNING'.
Otherwise there should be some checks like:

onTimeUpdate: () => {
  if (timerName.status === 'STOPPED') return;

  ...code
},

Good callback fn to add

  1. onTimeReset
  2. onTimePause
  3. onTimeStop
  4. onTimeStart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant