Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reordering of conversion units #8

Closed
riverofjanuary opened this issue Apr 10, 2024 · 13 comments · Fixed by #9
Closed

Allow reordering of conversion units #8

riverofjanuary opened this issue Apr 10, 2024 · 13 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request

Comments

@riverofjanuary
Copy link

Love this tool and one of the few I've found that works in the UI I like.

I would love to be able to reorder the conversion units. I understand now they're ordered by size (for example mm/cm/m/km) but for my use case I would love mm/cm/in/feet to be first under the input box. Any way to add a drag n drop to be able to do this. Thank you.

@ThiBsc ThiBsc added the enhancement New feature or request label Apr 10, 2024
@ThiBsc
Copy link
Owner

ThiBsc commented Apr 10, 2024

Hello @riverofjanuary Thank you for your feedback, I can add this feature, but I can't promise to be quick.
To know where to update the app, can you tell me if you use it from Google Play Store or from the FDroid store ?

@riverofjanuary
Copy link
Author

Hi! Thanks for the quick response. F-Droid.

@ThiBsc
Copy link
Owner

ThiBsc commented Apr 11, 2024

Ok, here a first draft, it's just the visual result but the feature is far from end.
Peek 10-04-2024 21-48'

If you like the result tell me and I'll go with it to implement the reorder behavior

@ThiBsc ThiBsc self-assigned this Apr 11, 2024
@riverofjanuary
Copy link
Author

That's perfect! So if I stop dragging and drop (eg km above m in your example), it would remain there permanently, until I redragged (or maybe you want to make a "reset all" button)?

On top of this: can it please remember the state somewhere in the app so if I close/reboot phone/etc it maintains that position?

Thank you again!

@ThiBsc
Copy link
Owner

ThiBsc commented Apr 11, 2024

Hello,
For the behavior, what I have in mind is indeed to store the order in a state to keep it over each close/reboot of the phone/app.
But if in an update I add a unit in a category, I'll reset the order with the default order because I don't want to deal with missing or non matching size/unit key etc.

But new unit is not at each update so it will be still userfirendly.
What do you think ?

@riverofjanuary
Copy link
Author

I think that's great and makes perfect sense. Thank you for being so open!

@ThiBsc ThiBsc linked a pull request Apr 12, 2024 that will close this issue
@ThiBsc ThiBsc closed this as completed in #9 Apr 13, 2024
@ThiBsc ThiBsc reopened this Apr 13, 2024
@ThiBsc
Copy link
Owner

ThiBsc commented Apr 13, 2024

The feature is done and published to the Google Play store, but to update the FDroid store, I have to update a file on their repo because since the 1.0.10, I updated the version to fix some security issues.
The process to compile is a little bit different with this newer version of react native so I need to update the yaml on fdroid repo before tag the source code as 1.0.11 (I need to remember how to do it and the process is not only depending on me so it can be a delay).
If you want this feature quickly, you still can use the app from the Google store.
I let the issue open while the fdroid is not updated because you are using it so I can't consider it as done.
Thank you again to using the app, I have no statistics about utilisation on FDroid so I'm happy to see that some people use it

@riverofjanuary
Copy link
Author

Thank you! I did get it originally through fdroid but can do google if necessary. Hope youre well :-)

@ThiBsc
Copy link
Owner

ThiBsc commented Apr 19, 2024

Issue open on fdroid to track and know how to update correctly the apk with the new version of node need by react and avoid generating a failed apk on fdroid
https://gitlab.com/fdroid/fdroiddata/-/issues/3244

@riverofjanuary
Copy link
Author

You rock!

@ThiBsc
Copy link
Owner

ThiBsc commented Apr 24, 2024

The PR has been merged on FDroid, so I guess the pipeline will run tonight, take me in touch to know if the yaml update generate a correct APK. I think the last version should be available tomorow for the v1.0.11

@ThiBsc
Copy link
Owner

ThiBsc commented Apr 30, 2024

The v1.0.11 is now available on FDroid store and the APK is working on my phone, I consider this issue as solved.
Don't hesitate if you have other ideas

@ThiBsc ThiBsc closed this as completed Apr 30, 2024
@riverofjanuary
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants