Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "Go home" link in page 404 #29

Closed
kcjpop opened this issue Apr 13, 2022 · 1 comment
Closed

bug: "Go home" link in page 404 #29

kcjpop opened this issue Apr 13, 2022 · 1 comment

Comments

@kcjpop
Copy link
Contributor

kcjpop commented Apr 13, 2022

What

image

Example: https://notes.ancaois.me/notes/404

Currently "Go home" in page 404 is linked to https://memos.pub/. It should be linked to the hosted homepage, e.g. https://notes.ancaois.me in this case.

@thien-do
Copy link
Collaborator

Hi @kcjpop thanks for reporting this issue. This is a serious issue as we commit to not having any reference to "memos.pub" in our members' pages.

This has been fixed: https://notes.ancaois.me/acbc

Screen Shot 2022-04-14 at 11 41 26

If you are interested in the fix:

  • 9a16c85 to avoid exposing the path to your source repo
  • 6a1adb5 to remove memos.pub references in error pages (in case of membership)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants