Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CURRENT_PROJECT_VERSION to 1 #61

Merged
merged 2 commits into from Sep 16, 2019
Merged

Set CURRENT_PROJECT_VERSION to 1 #61

merged 2 commits into from Sep 16, 2019

Conversation

Cedrick84
Copy link
Contributor

The CURRENT_PROJECT_VERSION key was missing in the project. I added this and set it to 1. After compiling the framework and opening the plist the CFBundleVersion is now found and appstore submission works again. We should consider proper automatic versioning.

@thii
Copy link
Owner

thii commented Sep 16, 2019

The diff on GitHub doesn’t look like it only contains this change. Could you check it again?

@Cedrick84
Copy link
Contributor Author

They will re appear the next time you open the project with xcode. But have inserted manually now.

Copy link
Owner

@thii thii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@thii thii merged commit e6f4532 into thii:master Sep 16, 2019
@Cedrick84 Cedrick84 deleted the bugfix/missing-bundle-version branch September 16, 2019 12:10
@thii
Copy link
Owner

thii commented Sep 16, 2019

This has been released in 1.3.1. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants