Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #85 Unresolved #88

Closed
ghost opened this issue Oct 10, 2021 · 4 comments
Closed

Issue #85 Unresolved #88

ghost opened this issue Oct 10, 2021 · 4 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Oct 10, 2021

Describe the bug
The menu neither offers a 'close' option, nor can I use other keybinds within it.
image

Technical Info:

  • OS: Windows 10
  • Version: 6.0.10
@thindil thindil self-assigned this Oct 10, 2021
@thindil
Copy link
Owner

thindil commented Oct 10, 2021

Hello, and problems again here. 😞

  1. The “Close” menu entry, as I wrote here was added only to the development version.
  2. The lack of shortcuts. Looks like Windows only problem, on Linux everything works as expected. I need to look closer on it. In Tk library, menus work differently on OS, thus maybe adding shortcuts to the open menu is impossible on Windows.

@thindil thindil added the bug label Oct 10, 2021
@ghost
Copy link
Author

ghost commented Oct 10, 2021

Hello, and problems again here. 😞

1. The “Close” menu entry, as I wrote [here](https://github.com/thindil/steamsky/issues/85#issuecomment-934755520) was added only to the development version.

2. The lack of shortcuts. Looks like Windows only problem, on Linux everything works as expected. I need to look closer on it. In Tk library, menus work differently on OS, thus maybe adding shortcuts to the open menu is impossible on Windows.

I mean, https://thindil.itch.io/steam-sky/devlog/302517/version-6010-is-here stated the patch occured within this version.

@thindil
Copy link
Owner

thindil commented Oct 10, 2021

Ah, I should be more descriptive in the patch, I'm sorry. The close menu should be only in the development version. But shortcuts should work in the stable version either. That's why I need to look at it.

@thindil
Copy link
Owner

thindil commented Nov 12, 2021

Better late than never. 😄 But this one finally fixed too. It took that long because I was redesigning other menus too. One, to keep everything in the same style. Two, because the problem could also appear there too. Thank you for the report and I hope for patience. 😁

@thindil thindil closed this as completed Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant