Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry class updates & RPC_Response backward compatibility #131

Merged
merged 22 commits into from
Apr 8, 2023

Conversation

imbeacon
Copy link
Member

@imbeacon imbeacon commented Apr 7, 2023

No description provided.

@imbeacon
Copy link
Member Author

imbeacon commented Apr 7, 2023

Hi @MathewHDYT ,

What do you think about these changes?
The main thing for checking is avoiding using ARDUINO_JSON_NAMESPACE.

@MathewHDYT
Copy link
Contributor

Sorry for the delay I had a look at the code and at the failed builds to check what is missing.

@imbeacon I created a pull request onto your fork so you can simply accept that pull request and then they should be merged into this one. It also includes some info on what I changed and why.

@MathewHDYT
Copy link
Contributor

MathewHDYT commented Apr 8, 2023

@imbeacon As you can see from the build checks the ESP32 and ESP8266 now compile successfully again even if using the newest version of ArduinoJson.

But that way of discerning between constructors will not work for non C++ STL boards, meaning we need a workaround for those boards.

Because std::integral is in the C++ STL header, which some Arduino boards do not include.

I'll try to find a fix that isn't to complicated if possible, but there is a high likelihood that I need to add my Struct workaround for Arduino boards again.

I'll create a pull request again once I found a way to fix the issue.

Until this has been resolved I wouldn't merge this pull request.

@MathewHDYT
Copy link
Contributor

@imbeacon The pull request has been created and fixes the problems with Arduino without using any complicated struct workarounds.

@MathewHDYT
Copy link
Contributor

MathewHDYT commented Apr 8, 2023

@imbeacon Would be nice if this pull request could be merged and released with all changes as version 0.10.0, the library.json has been renamed accordingly already.

Additionaly once this is merged issue 130 can be closed as well.

@imbeacon imbeacon merged commit 78c0abd into thingsboard:master Apr 8, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants