-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry class updates & RPC_Response backward compatibility #131
Conversation
Hi @MathewHDYT , What do you think about these changes? |
Sorry for the delay I had a look at the code and at the failed builds to check what is missing. @imbeacon I created a pull request onto your fork so you can simply accept that pull request and then they should be merged into this one. It also includes some info on what I changed and why. |
@imbeacon As you can see from the build checks the But that way of discerning between constructors will not work for non C++ STL boards, meaning we need a workaround for those boards. Because I'll try to find a fix that isn't to complicated if possible, but there is a high likelihood that I need to add my I'll create a pull request again once I found a way to fix the issue. Until this has been resolved I wouldn't merge this pull request. |
This reverts commit d62b7c9.
@imbeacon The pull request has been created and fixes the problems with Arduino without using any complicated |
No description provided.