Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard coded MQTT payload buffer size cause data lost #9

Closed
esonhon opened this issue Mar 5, 2019 · 3 comments
Closed

Hard coded MQTT payload buffer size cause data lost #9

esonhon opened this issue Mar 5, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@esonhon
Copy link

esonhon commented Mar 5, 2019

In ThingsBoard.cpp, there are many hard coded mqtt payload buffer size, such as
line 76: char payload[64];
etc...
In ThingsBoard.h
line 224:char payload[64];
etc...
Which causes data lost when payload size exceed the size.
Should we define some CONST and got the opportunity to send more data?
@forGGe
Copy link
Contributor

forGGe commented Mar 13, 2019

Hi @esonhon ! Thanks for reporting that.
Indeed, there should be a possibility to change a size of buffers in a compile time. Would you like to contribute?

@forGGe forGGe added the enhancement New feature or request label Mar 22, 2019
@forGGe
Copy link
Contributor

forGGe commented Apr 11, 2019

Work started in #15

@forGGe
Copy link
Contributor

forGGe commented Apr 22, 2019

Fixed in #15

@forGGe forGGe closed this as completed Apr 22, 2019
@vaipatel vaipatel mentioned this issue Sep 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esonhon @forGGe