OPC-UA gateway timeseries configuration handling error

[LilaLipetti]

While testing the OPC-UA, noticed that the attribute mappings and time series mappings doesn't work correctly.

While investigating the code in OpcUaDevice.java noticed following issue (lines 100-118):

public List<KvEntry> getAffectedAttributes(NodeId tagId, DataValue dataValue) {
        List<AttributesMapping> attributes = getAttributesMapping(tagId);
        if (attributes.size() > 0) {
            return getKvEntries(attributes);
        } else {
            return Collections.emptyList();
        }
    }

public List<TsKvEntry> getAffectedTimeseries(NodeId tagId, DataValue dataValue) {
        List<AttributesMapping> attributes = getAttributesMapping(tagId);
        if (attributes.size() > 0) {
            return getKvEntries(attributes).stream()
                    .map(kv -> new BasicTsKvEntry(dataValue.getSourceTime().getJavaTime(), kv))
                    .collect(Collectors.toList());
        } else {
            return Collections.emptyList();
        }
}

that in the getAffectedTimeseries the code is working against attribute mappings not against time series mappings.

The getAffectedTimeseries should me more like

public List<TsKvEntry> getAffectedTimeseries(NodeId tagId, DataValue dataValue) {
        List<TimeseriesMapping> tsattributes = getTimeseriesMapping(tagId);
        if (tsattributes.size() > 0) {
            return getKvEntries(tsattributes).stream()
                    .map(kv -> new BasicTsKvEntry(dataValue.getSourceTime().getJavaTime(), kv))
                    .collect(Collectors.toList());
        } else {
            return Collections.emptyList();
        }
}

[mp-loki]

Fixed in ThingsBoard Gateway versions 1.2.2 and 1.4.0