Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalculateDeltaNode make non-blocking on find latest telemetry #10336

Closed
smatvienko-tb opened this issue Mar 8, 2024 · 0 comments · Fixed by #10483
Closed

CalculateDeltaNode make non-blocking on find latest telemetry #10336

smatvienko-tb opened this issue Mar 8, 2024 · 0 comments · Fixed by #10483
Assignees
Milestone

Comments

@smatvienko-tb
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The problem is the CalculateDeltaNode makes a blocking call to the timeseriesService.findLatestSync
This blocks rule-dispatcher worker thread(s) and reduces the rule engine's overall performance and latency.

image

Describe the solution you'd like

Refactor the rule-node to call a truly async functions only
Remove or deprecate timeseriesService.findLatestSync as it is only place that uses

Describe alternatives you've considered

See the MathNode implementation on how to maintain ordered async executions in a non-blocking way

Additional context

ThingsBoard 3.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants