Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default fillna to be false and allow configurable fill value #64

Closed
Tracked by #42
jtmiclat opened this issue Jul 1, 2022 Discussed in #62 · 2 comments
Closed
Tracked by #42

Change default fillna to be false and allow configurable fill value #64

jtmiclat opened this issue Jul 1, 2022 Discussed in #62 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jtmiclat
Copy link
Contributor

jtmiclat commented Jul 1, 2022

Discussed in #62

Originally posted by mosesckim June 30, 2022
Noticed default is to fill NaNs with zero after aggregation; this might make it difficult to identify original NaNs if there are actual zeros in the aggregation.

https://github.com/thinkingmachines/geowrangler/blob/master/geowrangler/vector_zonal_stats.py#L205

Also, a suggestion would be, in the case fillna option is set to True, make the replacement value (0 in this case at the moment) a variable users can input (e.g. -1, etc.)

Thanks!
Moses

@jtmiclat jtmiclat added the enhancement New feature or request label Jul 1, 2022
@butchtm
Copy link
Collaborator

butchtm commented Jul 1, 2022

I'm setting this a good first issue for new contributors!

@butchtm butchtm added the good first issue Good for newcomers label Jul 1, 2022
@tm-kah-alforja tm-kah-alforja mentioned this issue Jul 1, 2022
12 tasks
@butchtm
Copy link
Collaborator

butchtm commented Jul 8, 2022

Implemented in #94

@butchtm butchtm closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

2 participants