-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry Validation: Catching polygons with less than 3 unique vertices #88
Comments
We actually have a broken polygon for slither in
A way to detect this is by getting the polygon area. Btw the polygon has an area. Is this correct?
|
Oh I computed the area on the projected polygon. Maybe it's a precision thing. The sample broken polygon you mentioned seems good! |
I just noticed, it it supposed to be slither or sliver? Just learned that sliver is the term for the polygon I made in my example (got it from overlaying two geometries). I wonder if it makes sense to have a minimum threshold for slivers |
I think i was intending for sliver but got the words jumbled up. I think we can catch the area being 0 as a default and if the user has more of a threshold they can build their own validator
|
Yep agree! |
This could be a feature to consider for Geowrangler Geometry Validation
I encountered an error where I tried to upload a geopandas dataframe to BQ and it said
It turns out there was a "polygon" that was actually a line. I verified it by computing the area which was actually 0.
The weird thing is it's not caught by
is_valid
on the epsg:4326 GeoSeries but it's caught byis_valid
when the GeoSeries was projected to epsg:3123. I expectedis_valid
to return FALSE even if the polygon was not projected.Perhaps this can be something geowrangler's geometry validation can also catch?
The text was updated successfully, but these errors were encountered: