Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Cypress after Heroku Deploy #88

Closed
oudeismetis opened this issue Jun 16, 2022 · 1 comment
Closed

Run Cypress after Heroku Deploy #88

oudeismetis opened this issue Jun 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@oudeismetis
Copy link
Member

Currently the Cypress tests run when the other tests run. The problem is that Heroku finishes deploying the new changes after the tests run, so the Cypress results are actually for the previous code push.

Better solutions:

  1. A Heroku post-deploy script makes an API call to Github (https://api.github.com/repos/{repo-name}/dispatches)
  2. The Github Action for Cypress is changes to only trigger on repository_dispatch

https://niteo.co/blog/staging-like-its-2020
@oudeismetis oudeismetis added the bug Something isn't working label Jun 16, 2022
@oudeismetis oudeismetis mentioned this issue Aug 22, 2022
Merged
12 tasks
@oudeismetis
Copy link
Member Author

A final fix for this was implemented in #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oudeismetis