Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implements #24

Closed
hidakatsuya opened this issue May 13, 2015 · 1 comment
Closed

Re-implements #24

hidakatsuya opened this issue May 13, 2015 · 1 comment
Assignees
@hidakatsuya
Labels
enhancement New feature or request

Comments

@hidakatsuya
Copy link
Member

Not good:

  • Shape の実装が Interface, Internal, Format クラスに分かれてて分かりにくい
  • Generator の実装が PDF 以外の出力フォーマットに対応できるようになっているが、今後 PDF 以外に対応するつもりはない。もっとシンプルに
  • Generator のクラス・モジュール構造が深すぎる
  • Test コード全部書き換え

などを考慮して再実装
@hidakatsuya hidakatsuya added the enhancement New feature or request label May 13, 2015
@hidakatsuya hidakatsuya self-assigned this May 13, 2015
@hidakatsuya hidakatsuya added this to the 1.0.0 milestone May 13, 2015
@hidakatsuya
Copy link
Member Author

Closed this issue, because i created PR #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hidakatsuya hidakatsuya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hidakatsuya