Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for adding get all listings method in Marketplace #147

Closed
adhbh opened this issue Apr 5, 2022 · 2 comments
Closed

Request for adding get all listings method in Marketplace #147

adhbh opened this issue Apr 5, 2022 · 2 comments

Comments

@adhbh
Copy link

adhbh commented Apr 5, 2022

Hello team,
The listings method here: https://github.com/thirdweb-dev/contracts/blob/main/contracts/marketplace/Marketplace.sol#L88
works well for getting listing by listingId

However, it would be really helpful to also include get all listings function in the contract.

@kaymen99
Copy link

kaymen99 commented Apr 5, 2022

[fix] I added a new function that allow user to get all listing

@nkrishang
Copy link
Member

Hey y'all 👋🏽

We're working on the next iteration of the Marketplace contract; you can track the effort, here: #259

We've added explicit view functions such as getAllListings and getAllValidListings that'll be included in this next iteration of the Marketplace contract: https://github.com/thirdweb-dev/contracts/blob/marketplace-v3/contracts/marketplace/direct-listings/DirectListingsLogic.sol#L301-L367

These view functions are not present in the current version of the Marketplace contract due to the contract crossing the smart contract size limit (~24.576 kb) on adding such view functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants