Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different public address from Magic #473

Closed
arnaudjnn opened this issue Dec 26, 2022 · 2 comments
Closed

Different public address from Magic #473

arnaudjnn opened this issue Dec 26, 2022 · 2 comments
Labels
wontfix This will not be worked on

Comments

@arnaudjnn
Copy link

I have two different public addresses for the following methods

import { EthNetworkConfiguration, Magic } from 'magic-sdk';

const magic = new Magic(process.env.NEXT_PUBLIC_MAGIC_API_KEY, {
  network: process.env.NEXT_PUBLIC_CHAIN_KEY as EthNetworkConfiguration,
});
await magic.auth.loginWithMagicLink({ email:  'myemail@gmail.com'  });

const provider = new ethers.providers.Web3Provider(magic.rpcProvider);
const magicSigner = provider.getSigner();
const address = await magicSigner.getAddress();
console.log(address)

and

import { useMagic, useAddress } from '@thirdweb-dev/react/evm/connectors/magic';
const connectWithMagic = useMagic();
const address = useAddress()

await connectWithMagic({ email: 'myemail@gmail.com' })
console.log(address)

Here is the Sandbox to reproduce the issue: https://github.com/rekolt/magic-link

If I use the same email, I should have one single address, correct? Why do I have two different?

@joaquim-verges
Copy link
Contributor

interesting. This might be because of the major version update magic did recentlyl. The react SDK uses an older version. We're working on an updated version in our new separate @thirdweb-dev/wallets package. Should help with this issue

@stale
Copy link

stale bot commented Mar 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 15, 2023
@stale stale bot closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants