Feature: lint less files with csslint #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
I don't mind using bootstrap's options here as long as it doesn't conflict with our styleguide
|
looking good so far 😄 |
|
@edwardoparearyee I've added csslint rules and also configured csscomb with rules from bootstraps example, these are mainly consistent with out styleguide anyway. CSScomb will ensure less rules are formatted consistently and properties are ordered consistently. |
|
👍 LGTM |
jamesjwarren
added a commit
that referenced
this pull request
Oct 12, 2015
Feature: lint less files with csslint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
Here is an example of some of the options available in the .cssslintrc file https://github.com/twbs/bootstrap/blob/master/less/.csslintrc
Bootstrap use this in combination with csscomb, so may be worth using that too.