global is undefined

[stevehu]

I am using brace from react-ace on Chrome browser with webpack and my app is broken due to global is undefined. You can reproduce it with my project https://github.com/networknt/react-schema-form

git clone git@github.com:networknt/react-schema-form.git
npm install
npm start

Then hit the url from your browser.
http://localhost:8080/webpack-dev-server/

The line of code failed.

    if (!global.document)
        return "";

Here is the line of the code I have changed as a work around. Just check if global is undefined before calling global.document.

    if (!global || !global.document)
        return "";

Does anyone know what is wrong? Is there any better workaround? Can this be fixed in the next release?

Thanks.

[thlorenz]

That's a webpack issue, brace is only meant to be used with browserify and run client side.

[stevehu]

I am using webpack on the client side only. Also, this is not about fix the defect only, but a defensive coding style. You have to make sure the global is defined before calling global.document. This will make this wonderful package work with webpack which is much more popular then browserify. Thanks for your consideration.

[thlorenz]

@stevehu you do realize that this code is just pulled in from Ace right?
I'm not going to apply changes here. brace is just an automatically adapted version of Ace.
Please file the issue there.

[stevehu]

@thlorenz Sorry. I didn't realize that it is in Ace codebase. I am opening an issue over there. Thanks for all the work you have done. I am using it but with my customized version installed from github:)

[thlorenz]

No worries, I had a feeling you weren't aware of that ;)