Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emojis in headings break links #123

Closed
adrianmcli opened this issue Feb 15, 2017 · 3 comments
Closed

Emojis in headings break links #123

adrianmcli opened this issue Feb 15, 2017 · 3 comments

Comments

@adrianmcli
Copy link

Pretty simple bug 馃悶

Steps to reproduce:

  1. Put an emoji on the same line as a heading.
  2. Run doctoc on it.
  3. Notice that the generated link does not work.
@thlorenz
Copy link
Owner

wow, I have no idea what to do about that.
Could you tell me what the generated link should look like?

If so please refile this issue in anchor-markdown-header and we can try to fix it there.

@adrianmcli
Copy link
Author

I tried it, and apparently it just leaves it out, but with a dash.

So I actually tried it out with a heading like this:

# Modules 馃摝

And the Markdown required is:

- [Modules](#modules-)

You can see it here: https://github.com/adrianmcli/next-boilerplate/blob/master/README.md

I will cross-post to anchor-markdown-header.

@adrianmcli adrianmcli mentioned this issue Feb 16, 2017
Closed
@adrianmcli
Copy link
Author

Continued in thlorenz/anchor-markdown-header#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thlorenz @adrianmcli