You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Package tests run a second connection with go irccon.Loop(), like here.
I've been using this code in my own libraries with -race and discovered a bunch of race conditions, such as github.com/thoj/go-ircevent.(*Connection).RunCallbacks() and github.com/thoj/go-ircevent.(*Connection).AddCallback()
These issues seem like they could easily be solved by adding some mutexes around unsafe operations like callback map access. I may have the time to fix this in the next few weeks, but I'm not sure.
The text was updated successfully, but these errors were encountered:
Package tests run a second connection with
go irccon.Loop()
, like here.I've been using this code in my own libraries with
-race
and discovered a bunch of race conditions, such asgithub.com/thoj/go-ircevent.(*Connection).RunCallbacks()
andgithub.com/thoj/go-ircevent.(*Connection).AddCallback()
These issues seem like they could easily be solved by adding some mutexes around unsafe operations like callback map access. I may have the time to fix this in the next few weeks, but I'm not sure.
The text was updated successfully, but these errors were encountered: