Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop() is not goroutine safe #67

Closed
Joshua-Anderson opened this issue Oct 9, 2015 · 2 comments
Closed

Loop() is not goroutine safe #67

Joshua-Anderson opened this issue Oct 9, 2015 · 2 comments

Comments

@Joshua-Anderson
Copy link

Package tests run a second connection with go irccon.Loop(), like here.

I've been using this code in my own libraries with -race and discovered a bunch of race conditions, such as github.com/thoj/go-ircevent.(*Connection).RunCallbacks() and github.com/thoj/go-ircevent.(*Connection).AddCallback()

These issues seem like they could easily be solved by adding some mutexes around unsafe operations like callback map access. I may have the time to fix this in the next few weeks, but I'm not sure.

@Joshua-Anderson Joshua-Anderson changed the title Loop() is not goroutine safe Loop() is not goroutine safe Oct 9, 2015
@thoj
Copy link
Owner

thoj commented Feb 6, 2016

Work in progress. Latest change will fix some of the issues. See da78ed5

@thoj
Copy link
Owner

thoj commented Nov 5, 2016

Most races has been fixed.

@thoj thoj closed this as completed Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants