-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser: Better Mobile UI #13
Comments
Well, currently the UI kind of requires a minimum resolution of What is your device resolution? Is it higher than 500px in screen width? If so, there might be some glitch with the I could probably cheat around that behaviour with the CSS |
I tested this with Huawei P20 which isn't so small phone 🙂. I've used Chrome for Android in PWA mode and I've got |
Hm... gsmarena says that the actual display resolution is Could you check what the |
@cookiengineer Yes, this is weird. |
The What happens if you change the - <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1, maximum-scale=1, user-scalable=no">
+ <meta name="viewport" content="initial-scale=1, minimum-scale=1, maximum-scale=1, user-scalable=no"> (removing the |
It is still same. |
Okay, after reading the css-device-adapt specification I guess the behaviour that is wanted for the Stealth Browser is this: <meta name="viewport" content="user-scalable=no"> ... because this will actually lead to the correct behaviour when navigating around, and will render the UI in the scale factor that is given by the device. If I'm gonna implement a |
I pushed the fix to Can you confirm that the UI looks not so broken on your mobile? |
What I don't understand in the screenshot is the relation between font-sizes. The baseline for all fonts is 16px font-size, and it's inherited by the Yet the radio elements in the settings are rendered in a completely different size compared to the surrounding content. Honestly I have no idea on how to fix this without messing up the rest of the codebase. Maybe with some setting for UI scale that then is applied via Gotta think about this one a bit. |
It took a very long while, but I've implemented a new UI today. The new UI will blend in a toggle button once the screen width is too small to fit in all the UI elements, which will toggle the Tab sidebar and the additional settings as an overlay. |
Current UI is sometimes broken on mobile. Below are some screenshots of broken things.
Some top icons (for settings) are in the separate line which is not styled:
Text sometimes overflows screen:
Inputs sometimes overflow screen:
The text was updated successfully, but these errors were encountered: