Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following Dot custom color #35

Merged
merged 3 commits into from Sep 16, 2022
Merged

Following Dot custom color #35

merged 3 commits into from Sep 16, 2022

Conversation

ZTF666
Copy link
Contributor

@ZTF666 ZTF666 commented Sep 15, 2022

I had the pleasure of implementing the trailing effect for one of our internal demos for a product and i got asked the following question so often : 'is it possible to change the color of the dot ?' , so i decided to make it happen lol .
I added a couple of lines to make custom colors possible for the following dot .
Cheers ,ZTF

I had the pleasure of implementing the trailing effect for one of out internal demos for a product and i got asked a question so often that i decided to make it happen lol .
So i added a couple of lines to make custom colors possible for the following dot .
Cheers ,ZTF
@tholman
Copy link
Owner

tholman commented Sep 15, 2022

Nice! Looks like the default color maybe doesn’t have its opacity any more though, fix that up and I’ll merge in!

@ZTF666
Copy link
Contributor Author

ZTF666 commented Sep 16, 2022

Thank you !
Correct me if i'm wrong , the opacity can be set through the hex value of the color if needed !? if i recall, the hex color representation does support the addition of an alpha value i.e : #RRGGBBAA .
So if for example if i choose a black color : #141414 i can add opacity to it by doing something like : #14141450 , thus making the dot have its opacity if needed .

@tholman
Copy link
Owner

tholman commented Sep 16, 2022

Right! The old default was rgba(50, 50, 50, 0.65) and in this PR its #5b5b5b, would like to keep that opacity on the default either as rgba(50, 50, 50, 0.65) or the hex with the alpha

Original color added with the possibility to change it if needed .
@ZTF666
Copy link
Contributor Author

ZTF666 commented Sep 16, 2022

Alright ! it has been done , thank you for the feedback 🙌.

@tholman
Copy link
Owner

tholman commented Sep 16, 2022

Thanks! Will do the npm deploy when i get a minute, but this is all great.

@tholman tholman merged commit cf92e2d into tholman:master Sep 16, 2022
@ZTF666
Copy link
Contributor Author

ZTF666 commented Sep 16, 2022

Thank you ! cheers 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants