Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapitre 3 : double appel à uppercaseAsync ? #50

Closed
oliverpool opened this issue Jul 14, 2016 · 1 comment
Closed

Chapitre 3 : double appel à uppercaseAsync ? #50

oliverpool opened this issue Jul 14, 2016 · 1 comment

Comments

@oliverpool
Copy link
Contributor

Dans message-abbr-promisified.js, il me semble que la fonction uppercaseAsync est appelé 2 fois (alors qu'une fois devrais suffire):

module.exports = function messageAbbr(message){
  return new Promise(function(resolve, reject){
    return uppercaseAsync(message)
      .then(uppercaseAsync)
      .then(splitWordsAsync)
      .then(abbreviateAsync)
      .then(resolve)
      .catch(reject);
  });
};
@oliverpool oliverpool changed the title Chapitre 3 : double appel à uppercaseAsync Chapitre 3 : double appel à uppercaseAsync ? Jul 14, 2016
@thom4parisot
Copy link
Owner

Toutafé, bonne remarque ! :-)

Si tu changes le code et soumets une PR, je l'accepterai aussitôt :-)

Merci et bien vu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants