Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package is 18 MB because of included bower_components directory with tal #64

Closed
dylang opened this issue Oct 13, 2015 · 1 comment · Fixed by #65
Closed

npm package is 18 MB because of included bower_components directory with tal #64

dylang opened this issue Oct 13, 2015 · 1 comment · Fixed by #65
Labels

Comments

@dylang
Copy link

dylang commented Oct 13, 2015

The node module was published with a bower_components directory from tal, which in turn includes a bunch of binaries:

/tldjs/bower_components/tal/static/vendor/cache ❯ dir
total 10204
drwxr-xr-x 12 dylang staff     408 Oct 13 13:47 .
drwxr-xr-x  3 dylang staff     102 Jul 21  2014 ..
-rw-r--r--  1 dylang staff   25600 Jul 21  2014 childprocess-0.3.9.gem
-rw-r--r--  1 dylang staff  879616 Jul 21  2014 ffi-1.4.0.gem
-rw-r--r--  1 dylang staff  148992 Jul 21  2014 json-1.8.0.gem
-rw-r--r--  1 dylang staff   28672 Jul 21  2014 multi_json-1.7.7.gem
-rw-r--r--  1 dylang staff  119808 Jul 21  2014 rake-10.0.3.gem
-rw-r--r--  1 dylang staff  415232 Jul 21  2014 rubygems-update-2.2.1.gem
-rw-r--r--  1 dylang staff   31744 Jul 21  2014 rubyzip-0.9.9.gem
-rw-r--r--  1 dylang staff 2849280 Jul 21  2014 selenium-webdriver-2.35.1.gem
-rw-r--r--  1 dylang staff 5908480 Jul 21  2014 tal-test-runner-0.0.1.1390678128.gem
-rw-r--r--  1 dylang staff   22528 Jul 21  2014 websocket-1.0.7.gem

bower_components could be added to the .gitignore, bump the version, and publish to fix this problem.

@thom4parisot
Copy link
Owner

Oops, indeed — it should not have been the case as this package has nothing to do with tld.js.

Thanks for the heads up, will the change right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants