Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tldjs Browser on Bower #89

Closed
Adrion opened this issue Feb 8, 2017 · 4 comments
Closed

Tldjs Browser on Bower #89

Adrion opened this issue Feb 8, 2017 · 4 comments

Comments

@Adrion
Copy link

Adrion commented Feb 8, 2017

Hi,
I saw #37 and I'm asking why bower dependency isn't the browserified version ?

@thom4parisot
Copy link
Owner

Hi @Adrion, I don't use bower – do you mean that the dependencies listed in bower.json are different than the ones in the package.json?

@Adrion
Copy link
Author

Adrion commented Feb 13, 2017

I use bower to seperate client dependencies and npm for non-client.
The idea is to have a client-ready lib inside bower dependency. like a dist/ folder with a pre-browserified version :)

@thom4parisot
Copy link
Owner

Thank you for the details.

I'm not sure it is a good way to version "dynamic" content in git. I would rather push for dist artefacts to be built at CI and published in the npm package (which is the way #91 headed over for the rules bundling).

Why not using npm to manage tldjs and to bundle it the way you need for the browser?

@Adrion
Copy link
Author

Adrion commented Feb 14, 2017

It was more for consistency of 3rd party libs and build workflow, I can live with it don't worry ^^

But yes an artefact on the package (not repos) can be a good solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants