Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating PR's in GHES (GitHub enterprise server) behind proxy #39

Closed
sethumadhav07 opened this issue Jun 1, 2021 · 1 comment · Fixed by #41
Closed

Comments

@sethumadhav07
Copy link

sethumadhav07 commented Jun 1, 2021

Currently 'create-pull-request' can't create PR's in GHES and behind proxy. Is it possible to add support? That would be a very nice addition.

octokit constructor has options to include base url as well as proxy : https://github.com/octokit/octokit.js#constructor-options

e.g.

const proxy = new HttpsProxyAgent(process.env.http_proxy);
   let octokit = new Octokit({
      baseUrl: `${baseurl}/api/v3`,
      request: {
        agent: proxy,
      },
    });

Is it also possible to improve on additional outputs (e.g. html_url) instead of constructing url ourselves?

const html_url = pullRequest.data.html_url;
 setOutput("html_url", html_url);
@thomaseizinger
Copy link
Owner

Currently 'create-pull-request' can't create PR's in GHES and behind proxy. Is it possible to add support? That would be a very nice addition.

Yep, I would accept a PR for that.

Is it also possible to improve on additional outputs (e.g. html_url) instead of constructing url ourselves?

Yep, also happy to accept a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants