Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI build? #36

Closed
FranklinChen opened this issue Jul 30, 2019 · 2 comments
Closed

Add Travis CI build? #36

FranklinChen opened this issue Jul 30, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@FranklinChen
Copy link

It might be a good idea to add a Travis CI build. I just did npm install and it failed at

> install-purescript --purs-ver=0.12.5

so something's wrong.

@thomashoneyman
Copy link
Owner

I agree, this should have a continuous integration build. I'm most familiar with Circle CI, but I'm also open to Travis. I can do this at some point soon, but if anyone else would like to submit this as PR I welcome that, too!

With regards to your failure installing PureScript, I should have updated the dependency to be purescript: 0.13.2 and overlooked it. You're right that this could be caught by continuous integration.

In this case, I believe you're seeing a failure because of this problem with the NPM installer for PureScript. Installing PureScript 0.13.2 should work instead.

I've updated the dependency in the master branch if you'd like to checkout again.

@thomashoneyman thomashoneyman self-assigned this Jul 30, 2019
@thomashoneyman thomashoneyman added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 30, 2019
@thomashoneyman
Copy link
Owner

@FranklinChen I've added continuous integration via Circle CI and a badge to the README displaying the build status. Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants