Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB_DAYS_TO_KEEP #1076

Merged
merged 6 commits into from
Mar 21, 2022
Merged

WEB_DAYS_TO_KEEP #1076

merged 6 commits into from
Mar 21, 2022

Conversation

EricClaeys
Copy link
Collaborator

  • Similar to NIGHTS_TO_KEEP, but for web files i /var/www/html/allsky.
  • Renames NIGHTS_TO_KEEP to DAYS_TO_KEEP because it keeps/deletes a full day's worth of images, not just nighttime images.

Added new WEB_NIGHTS_TO_KEEP setting to config.sh that specifies how many days of images to keep in the website, if it's installed.
This is similar to NIGHTS_TO_KEEP.
* Renamed "NIGHTS_TO_KEEP" to "DAYS_TO_KEEP" since it determines how many days' data is kept, not just nighttime data.
* Removed the "AUTO_DELETE" variable; instead, if "DAYS_TO_KEEP" is "", then all days are kept, otherwise only the specified number of days are kept.  This eliminates one variable while keeping the old functionality.
* Added "WEB_DAYS_TO_KEEP" to clean out the Allsky website files.
* Renamed $NIGHTS_TO_KEEP to $DAYS_TO_KEEP since it applies to days, not just nights.
* Added ${ME} to log messages so it's clear where they are coming from.
* Removed $AUTO_DELETE since if $DAYS_TO_KEEP is "" ALL days are kept (same as old AUTO_DELETE=false).
Comment on lines 164 to 169
# If you have additional data or buttons you want displayed on the WebUI's System page,
# specify one or more colon-separated files that contain that data.
# You must provide scripts to update those files.
# See the WEBUI_DATA_FILES configuration variable in the "Software settings" section of
# https://github.com/thomasjacquin/allsky/wiki/allsky-Settings for details.
WEBUI_DATA_FILES=""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've based this branch out of another one instead of master but that shouldn't be a problem. You may end up with a merge conflict but it should resolve easily

Copy link
Collaborator Author

@EricClaeys EricClaeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now

@EricClaeys EricClaeys merged commit 4714c1f into master Mar 21, 2022
@EricClaeys EricClaeys deleted the WEB_DAYS_TO_KEEP branch March 21, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants