Gui/install fixes and changes #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files should be 644, not 775.
ifconfig needs to be in the file in order for the start/stop network buttons in the WebUI to work.
1. Add the "thumbnails" directory to the list where buffering is turned off. Without this, new thumbnails didn't appear until ALL of them were created, and with video thumbnails that could be half a minute, and the user would think the page hung. 2. Remove the "compress" lines since we aren't doing compression. With the lines there, it produces two warnings in the log file.
* Put { } around variables to be consistent.
* Add quotes around some variables.
* No longer any need to replace only the FIRST instance of XX_ALLSKY_HOME_XX in funciton.php, so removed that comment and code.
* Merged the "sed -i" statements from 3 to 2, and added WEBSITE_DIR.
Since "ifconfig" is being added in the PR to "sudoers", check for it during installation.
To be consistent with all other variables pointing to directories, add ALLSKY_WEBUI and ALLSKY_WEBSITE. The old names will go away in a future release.
And add ALLSKY_WEBSITE which is needed by the WebUI.
* Add a placeholder for "website" which is needed by the WebUI. * To be consistent with other installation scripts, use placeholders that will be replaced during installation.
thomasjacquin
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few bugs with gui/install.sh, lighttpd.conf, and sudoers.
This PR replaces the original one that was based on the "dev" branch and shouldn't have been.