Improvements to process locking #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
EricClaeys
commented
Jun 10, 2023
EricClaeys
commented
- Improve the way process locking is done and the aborted messages.
- The files listing the aborted processes are all in a sub-directory in allsky/tmp.
- Create a global make_thumbnail() function rather than using the one defined in a scripts/*.sh file. More scripts will use this via another PR.
- Many other changes that aren't related to process locking, but hey, I was already editing the files...
* Use new "--caused-by" argument to one_instance(). * Specify the time to wait for one_instance() so it doesn't wait too long. * Set AS_TEMPERATURE_C if not already set and there's a temperature.txt file. * Only call darkCapture.sh if needed. * Use new arguments to timelapse.sh.
* Accept new "--caused-by" argument. * Don't bother checking that the process in the PID_FILE is the specified one. --process-name is no longer needed. * Use new $ALLSKY_ABORTS_DIR.
* We're only called if taking dark frames, so no need to check. This changed indentation. * saveImage.sh updates AS_TEMPERATURE_C as needed so we don't need to.
* Accept new --lock, --output, and --images argument. * Updated usage message. * Updated usage checks. * Only check for valid DATE and DATE_DIR is needed.
* Accept new --lock, --output, and --images argument. * Updated usage message. * Updated usage checks. * Only check for valid DATE and DATE_DIR is needed.
…rectories. Also, make sure the PID_FILE is removed.
The prior way of creating the SEQUENCE_DIR files was to use gawk and a couple sub-shells. The new way which is simpler (and hopefully faster) uses a "while read" loop.
* Pass output timelapse file name to timelapse.sh. * Use global make_thumbnail() instead of our own version. * Show preferred "--" arguments instead of "-". * Change some indentation to make code easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.