gui-install.sh bug fix #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variables.sh is in $ALLSKY_HOME, not $ALLSKY_HOME/config.
These are used by the gui/install.sh and website/install.sh scripts which needed changing due to new locations for allsky config files.
ckuethe
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Seems ok. Somewhere down the road I think it would be great if we could keep all of the config in one place, eg. $ALLSKY_HOME/config and put some handy symlinks in /etc/raspap and /var/www/html so that config pieces aren't littered all over the place. But that's not required in this diff.
|
@ckuethe That's our goal, to have all allsky-related config files in one directory. Until we implement the "one big config file" that combines config.sh, ftp-settings.sh, camerauto.sh, settings*.json, and camera_options_*.json, we may need symbolic links in the old locations. |
|
Don't look too carefully at the symlinks on my Pi without welding goggles... you'll go blind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variables.sh is in $ALLSKY_HOME, not $ALLSKY_HOME/config.