Gui install fix - Only replace 1st instance of XX_ALLSKY_HOME_XX
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #709
Resolves #706
In
functions.phpfrom allsky-portal, theinstall.shscript replaced every instance ofXX_ALLSKY_HOME_XX, including the one which is tested against to ensure the value has been set -away- fromXX_ALLSKY_HOME_XX. This means that it will always evaluate as if the defined variable hasn't been modified, since the value will always be the same as the define.This patch lets the modification only occur to the first instance of
XX_ALLSKY_HOME_XX, and not the second -- preserving the intent of the conditional check.