RPiHQ libcamera+raspistill #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't assume the extension of the dark frame is the same as the light frame. It the future the dark will likely by .png and the light .jpg.
Work with $CURRENT_IMAGE passed to us (in the future), or not passed to us (present).
Use $DARKS_DIR instead of $ALLSKY_DARKS, since in the future when darks are supported per-camera, DARKS_DIR will point to the camera-specific directory.
Also added {} around some variables.
Added/changed some comments for clarity.
Based on a new command-line argument, work with either raspistill or libcamera-still.
Pass the new "-cmd" option to the capture_RPiHQ command to let it know which command to use.
capture_RPiHQ.cpp sets the value of some variables based on whether or not libcamera or raspistill is being used.
Fixed saturation and brightness boundaries on libcamera. Remove a few unnecessary comments. Update some Log messages to display friendlier times. Reorders some statements to be more like ZWO capture. Made the "Starting ..." statements like ZWO. Set initial exposure to user-specified values, like ZWO does.
Indented to make easier to find in log file and to be like ZWO.
Remove "asi" from variable names. Don't write to test.jpg since we never read it. Clarify some Log messages.
It's now in the capture file.
RPiHQcalcMean() now returns the mean. Removed debugLevel since it was redundant with the global debugLevel. Clarified some comments. Aligned values and comments.
and fix a Log() message
Renamed a bunch of variables to get rid of "asi". Added and/or uncommented a lot of ZWO variables because we can now use them. capture function now reads the file just saved and puts into cv::Mat. "exposure" is set by capture function to the exposure used.
Added functions to display text and display units of time consistently. Deleted some useless Log messages and comments. Added #define's to be compatible with ZWO.
Added code to handle changing bins in overlay text
Print better message when starting exposure. Print better message when sleeping.
It's obsolete
Added missing command-line arguments and moved some others to be near similar arguments. Moved some curley braces and indented properly in a few places.
…we have to calculate the startpoint for ExposureLevel
The relationship between ZWO gain (unit 0.1 dB) and gain should be reviewed. My guess: gain = 10 ^ (ZWO gain / 20) In the future, the ZWO control should also use the exposure time and gain for allsky the pictures should be the same with these settings: 10s, ZWO gain 200 100s, ZWO gain 0 60s, ZWO gain 73 Can someone test this for me with a ZWO camera?
AndreasLMeg
reviewed
Nov 26, 2021
AndreasLMeg
reviewed
Nov 26, 2021
Cleanup: bullseye has problems to detect cameras - workaround
Cleanup: ZWO gain=0.1 dB , RPiHQ gain=factor
cleanup: first exposure with currentRaspistillSetting.shutter_us, so …
AndreasLMeg
approved these changes
Dec 3, 2021
"asi" is specific to ZWO cameras
linuxkidd
approved these changes
Dec 3, 2021
|
now this branch has been deleted there is no workaround to getting the HQ camera working |
|
@Shand359 we merged the branch so it's official now. You can grab the latest files from GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.