Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching sunwait to clear compile warnings #983

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

linuxkidd
Copy link
Collaborator

Upstream PRs sunwait#24 and sunwait#29 have sat for 30+ days with no action. Patching here to clean up our compile messages.

Upstream PRs have sat for 30+ days with no action.  Patching here
to clean up our compile messages.
@linuxkidd linuxkidd added bug needs software change confirmed labels Jan 29, 2022
@linuxkidd linuxkidd mentioned this pull request Jan 29, 2022
@linuxkidd
Copy link
Collaborator Author

New make all results:

 make[1]: Entering directory '/home/runner/work/allsky/allsky/src'
2022-01-29 22:36:48 Building capture program...
2022-01-29 22:36:52 Done.
2022-01-29 22:36:52 Building capture_RPiHQ program...
2022-01-29 22:36:57 Done.
2022-01-29 22:36:57 Building startrails program...
2022-01-29 22:37:01 Done.
2022-01-29 22:37:01 Building keogram program...
2022-01-29 22:37:06 Done.
2022-01-29 22:37:06 Initializing sunwait submodule...
Submodule 'src/sunwait-src' (https://github.com/risacher/sunwait) registered for path 'sunwait-src'
Cloning into '/home/runner/work/allsky/allsky/src/sunwait-src'...
Submodule path 'sunwait-src': checked out '102cb417ecbb7a3757ba9ee4b94d6db3225124c4'
2022-01-29 22:37:1643495827 Patching sunwait compile warnings...
patching file sunriset.cpp
patching file sunwait.cpp
2022-01-29 22:37:07 Building sunwait...
make[2]: Entering directory '/home/runner/work/allsky/allsky/src/sunwait-src'
gcc -c -Wall  sunwait.cpp -o sunwait.o
gcc -c -Wall  sunriset.cpp -o sunriset.o
gcc -c -Wall  print.cpp -o print.o
gcc sunwait.o sunriset.o print.o -o sunwait -lm -lstdc++
make[2]: Leaving directory '/home/runner/work/allsky/allsky/src/sunwait-src'
2022-01-29 22:37:08 Done.
make[1]: Leaving directory '/home/runner/work/allsky/allsky/src'
make[1]: Entering directory '/home/runner/work/allsky/allsky/config_repo'
2022-01-29 22:37:08 nothing to do for all
make[1]: Leaving directory '/home/runner/work/allsky/allsky/config_repo'
make[1]: Entering directory '/home/runner/work/allsky/allsky/notification_images'
2022-01-29 22:37:08 nothing to do for all...
make[1]: Leaving directory '/home/runner/work/allsky/allsky/notification_images'
make[1]: Entering directory '/home/runner/work/allsky/allsky/scripts'
2022-01-29 22:37:08 nothing to do for all
make[1]: Leaving directory '/home/runner/work/allsky/allsky/scripts'

Copy link
Collaborator

@AndreasLMeg AndreasLMeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it compiles. But I have made no source code check.

Copy link
Collaborator

@AndreasLMeg AndreasLMeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if that doesn't make the system more complicated. But no matter, sunwait is probably no longer maintained anyway

@linuxkidd linuxkidd merged commit 4ddacdb into AllskyTeam:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs software change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants