Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a bug in the test for CaseSensitivity in the Engine... #7

Closed
adrianoconnor opened this issue Feb 3, 2019 · 1 comment
Closed

Comments

@adrianoconnor
Copy link

Hi there,

I was looking at your project to try and figure a few things out (I was curious to see if the inline styles work better for pasting code in to a document...) and I spent a little while playing with it. While I was in there, I spotted a small bug in the Engine...

if (definition.CaseSensitive) {
  return DefaultRegexOptions | RegexOptions.IgnoreCase;
}

The check is the wrong way around, it should be: if (definition.CaseSensitive == false).

I've changed it in my cloned repo, and added a test for it; happy to send over a PR if you care. Wanted to post this here just on the off-chance somebody else hits the same thing and wonders why :)

Many thanks!
Adrian

@thomasjo
Copy link
Owner

thomasjo commented Feb 6, 2022

Fixed in #8

@thomasjo thomasjo closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants