Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled notification events #14

Closed
atymic opened this issue Sep 25, 2019 · 4 comments
Closed

Scheduled notification events #14

atymic opened this issue Sep 25, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@atymic
Copy link
Collaborator

atymic commented Sep 25, 2019

I think we should add an event dispatched before and after a notification is sent.

It would allow the application to do some checks before the notification is sent (ie, ensure that the user is still active, etc) and after (record that x email was sent)

@thomasjohnkane
Copy link
Owner

Could we handle this with just having a method on the notification class like shouldStillSend() to check to see if sending is still required? You can already log that a notification was sent in the toArray() method of the notification class.

I'm going to create a PR for the should still send check, and we can discuss events down the road if there's a more concrete example.

@atymic
Copy link
Collaborator Author

atymic commented Oct 15, 2019

I was actually thinking of doing it that way, but didn't have a chance to get it implemented yet :)

Thanks for doing the PR, will check it out now :)

I think it's probably still worth firing an event on sent (at least)

@atymic atymic added the enhancement New feature or request label Oct 15, 2019
@atymic atymic closed this as completed Oct 17, 2019
@LeonAlvarez
Copy link

Is this implemented?

@atymic
Copy link
Collaborator Author

atymic commented Feb 21, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants