Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProfileStateMachine #61

Closed
3 tasks done
thomaskioko opened this issue Apr 1, 2023 · 0 comments · Fixed by #88
Closed
3 tasks done

Refactor ProfileStateMachine #61

thomaskioko opened this issue Apr 1, 2023 · 0 comments · Fixed by #88
Labels
android Android related task/issues enhancement New feature or request ios iOS related task/issue shared Shared module task/issues

Comments

@thomaskioko
Copy link
Owner

thomaskioko commented Apr 1, 2023 •
edited

Description

Right now, ProfileStateMachine is in the Android feature module. We need to move it to the shared module to access it on the iOS Client.

  • Create profile module in shared domain layer.
  • Refactor TraktManager or update ProfileStateMachine parameters.
  • Create a helper function to save the AuthState & token

P.S It would be great to have #58 done first.
@thomaskioko thomaskioko added android Android related task/issues ios iOS related task/issue shared Shared module task/issues enhancement New feature or request labels Apr 1, 2023
@thomaskioko thomaskioko changed the title Profile StateMachine Refactor Refactor ProfileStateMachine Apr 1, 2023
@thomaskioko thomaskioko mentioned this issue Apr 3, 2023
Closed
2 tasks
@thomaskioko thomaskioko mentioned this issue Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android Android related task/issues enhancement New feature or request ios iOS related task/issue shared Shared module task/issues
Projects
@c0de-wizard's TvManiac
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Profile improvements thomaskioko/tv-maniac
1 participant
@thomaskioko