Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup title styling seems to be broken sometimes (Possibly a Light/Dark mode issue) #604

Closed
4 tasks done
steven-hack opened this issue Jul 14, 2023 · 1 comment
Closed
4 tasks done

Comments

@steven-hack
Copy link

My Home Assistant version: 2023.6.1 (happens for a few versions atleast)

What I am doing:
I am displaying a simple popup using the browser_mod.popup service. The displayed title is display incorrectly, without proper styling. (seems to be happening with every popup, both in the browser as in the mobile app)

What I expected to happen:
The title should be displayed correctly, like this:
afbeelding

With the given HTML markup when inspecting:
afbeelding

What happened instead:
The title appears without styling, below the closing icon:
afbeelding

The HTML markup seems to be different as well (missing a lot):
afbeelding

Minimal steps to reproduce:
I am not really sure. At first I thought this was an issue with Dark mode, so I switched to Light mode and it worked correctly. I then switched to a different browser (in private mode) also to Light mode to create the above screenshots. Except it now also didn't work properly in Light mode. Switching back and forth between Light/Dark mode and refreshing the page resulted in it working once, but haven't been able to reproduce is consistenly since. Ofcourse the difference in HTML markup is also interesting.

service: browser_mod.popup
data:
  title: Just a test
  content: Good for you

Error messages from the browser console:

BROWSER_MOD 2.2.2 IS INSTALLED
    BrowserID: c830ef66-33b4d7cc [browser_mod.js:407:6188](https://[redacted].duckdns.org:1337/browser_mod.js)
HUI-ELEMENT 1.1.2 IS INSTALLED <empty string> [hui-element.js:1:1813](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-hui-element/hui-element.js?hacstag=249942054180547)
SLIDER-ENTITY-ROW 17.3.0 IS INSTALLED <empty string> [slider-entity-row.js:82:184](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-slider-entity-row/slider-entity-row.js?hacstag=1448997001730)
 MULTIPLE-ENTITY-ROW  4.5.0 [multiple-entity-row.js:1:26787](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-multiple-entity-row/multiple-entity-row.js?hacstag=178921037441)
Automatisch afspelen is alleen toegestaan wanneer goedgekeurd door de gebruiker, de website is geactiveerd door de gebruiker, of media wordt gedempt. [browser_mod.js:66:14748](https://[redacted].duckdns.org:1337/browser_mod.js)
AUTO-ENTITIES 1.12.1 IS INSTALLED [auto-entities.js:172:7850](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-auto-entities/auto-entities.js?hacstag=1677445841121)
FOLD-ENTITY-ROW 2.2.0 IS INSTALLED <empty string> [fold-entity-row.js:78:255](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-fold-entity-row/fold-entity-row.js?hacstag=150781994220)
banner-card: 0.12.0 [banner-card.js:162:2393](https://[redacted].duckdns.org:1337/hacsfiles/banner-card/banner-card.js?hacstag=1867657040130)
TEMPLATE-ENTITY-ROW 1.3.2 IS INSTALLED <empty string> [template-entity-row.js:49:267](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-template-entity-row/template-entity-row.js?hacstag=231674882132)
 QR-CODE-GENERATOR  v1.0.2 [qr-code-card.js:170:17952](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-qr-code-card/qr-code-card.js?hacstag=449381321102)
vertical-stack-in-card
Version: 0.4.4 [vertical-stack-in-card.js:1:9](https://[redacted].duckdns.org:1337/hacsfiles/vertical-stack-in-card/vertical-stack-in-card.js?hacstag=142051833044)
 MINI-GRAPH-CARD  0.11.0 [mini-graph-card-bundle.js:1:95970](https://[redacted].duckdns.org:1337/hacsfiles/mini-graph-card/mini-graph-card-bundle.js?hacstag=1512800620110)
  TEXT-DIVIDER-ROW  
  Version 1.4.1     [text-divider-row.js:187:2171](https://[redacted].duckdns.org:1337/hacsfiles/text-divider-row/text-divider-row.js?hacstag=179788256141)
LAYOUT-CARD 2.4.4 IS INSTALLED [layout-card.js:228:115](https://[redacted].duckdns.org:1337/hacsfiles/lovelace-layout-card/layout-card.js?hacstag=156434866244)

By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:

  • Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).

  • Have made sure I am using the latest version of the plugin.

  • Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.

  • Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.

@steven-hack steven-hack changed the title Title popu styling seems to be broken sometimes (Possibly a Light/Dark mode issue) Popup title styling seems to be broken sometimes (Possibly a Light/Dark mode issue) Jul 14, 2023
@thomasloven
Copy link
Owner

Fixed by #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants