Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup is stretched to the entire window in the android app home assistant #606

Open
andrey170183 opened this issue Jul 15, 2023 · 20 comments

Comments

@andrey170183
Copy link

My Home Assistant version: 2023.7.2

What I am doing:
Updated browser_mod to version 2.3.0

What I expected to happen:
Open in a small window as before before the update

What happened instead:
popup opened for the whole window in the android app home assistant

Minimal steps to reproduce:
Just updated browser_mod to version 2.3.0
Screenshot_20230715-190309149

@WW1983
Copy link

WW1983 commented Jul 16, 2023

Same on iPhone

@K-RAD
Copy link

K-RAD commented Jul 17, 2023

Same here (Android 13)

@limitless00net
Copy link

same here..

@rob-oravec
Copy link

Me too - iPhone. Have tried pretty much everything (I think) - style changes, size changes as per documentation, theme changes, clear cache.

@Namsikjo
Copy link

I'm having the same problem too. (iPhone14Pro iOS17, iPhone11Pro iOS16)

@Lux315
Copy link

Lux315 commented Jul 23, 2023

Got this issue aswell.

Seems to be the same
issue like here: #617

@thomasloven Could you please take a look?

@suheilpurewal
Copy link

same issue for me on Android (Pixel 7 pro) & iPhone (14 pro max). Seems to be working fine on iPad & PC/Mac.

@ASNNetworks
Copy link

same issue for me on Android (Pixel 7 pro) & iPhone (14 pro max). Seems to be working fine on iPad & PC/Mac.

True, it affects popups on mobiles only. Basically devices that show the default more-info dialogs in a window are unaffected. Devices that show the more-info dialogs in a fullscreen manner (the core dialogs) now also show browser_mod popups in fullscreen (with a bugged out header).

@roderik-maker
Copy link

A temporary and not optimal fix, is to install card_mod and add the following to your popup cards:
(For IOS, haven't yet tested on android)

card_mod:
  style: |
    ha-dialog {
      --mdc-dialog-min-height: 10px !important;
    }

This returns the popups to a small size however, they are now at the bottom of the screen. I haven't yet figured out how to move them back up, but at least you don't have to quit the app to close a popup (This should help until a proper fix is implemented).

Example of full popup card:

type: custom:popup-card
title: Custom popup
dismissable: true
card:
  type: markdown
  content: This replaces the more-info dialog
right_button: right
left_button: left
entity: input_button.battery
card_mod:
  style: |
    ha-dialog {
      --mdc-dialog-min-height: 10px !important;
    }

@jbrandek
Copy link

jbrandek commented Aug 10, 2023

Ive bee able to fix it the problem is in browser_mod.js and browser_mod.js.gz on media querry 450px
you should change it to this:

@media all and (max-width: 450px), all and (max-height: 500px) {
ha-dialog {
--mdc-dialog-min-width: 97vw;
--mdc-dialog-max-width: 97vw;
--mdc-dialog-min-height: 10%;
--mdc-dialog-max-height: 100%;
}
then delete cache

i leave the files if someone does not know how to edit them, just delete the ones from custom_components/browser_mod/

and replace this 2

dont know how to edit in github if someone knows please upload them so they are kept in next update
browser_mod.zip

@Razzer90
Copy link

THX! Works on IOS!

@ve1koz111
Copy link

#617 Fix at the bottom

@smeen89
Copy link

smeen89 commented Sep 12, 2023

I too have this issue. And I've tried the mentioned solutions to no avail. I'm on Android app on a OnePlus 9 Pro.

What it looked like:
Screenshot_2023-09-12-15-54-35-29_b72a20be883aec8a014bd2b7c7038e87

What it looks like now:
Screenshot_2023-09-12-15-54-24-69_c3a231c25ed346e59462e84656a70e50

@ve1koz111
Copy link

@smeen89 #617 (comment)

@smeen89
Copy link

smeen89 commented Sep 15, 2023

@ve1koz111

You beautiful magician! This has been bugging me for so long and now it works! Great job!

@ASNNetworks
Copy link

ASNNetworks commented Oct 5, 2023

@ve1koz111 thank you so much for your fix. I tried it and works just like it should :) Hopefully @thomasloven will merge with the official.

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 15, 2023
@JoaoPedro13
Copy link

this is still an issue, replacing the files did not do the trick for me

@stale stale bot removed the stale label Feb 14, 2024
@thomasloven
Copy link
Owner

Could someone please post a screenshot of what the normal non-browser_mod more-info dialog popup looks like on the android app?

@Dino-Tech
Copy link

Dino-Tech commented Feb 19, 2024

@thomasloven 1st one is BM
Screenshot_20240219-171224
Screenshot_20240219-171349
Screenshot_20240219-171422
Screenshot_20240219-171522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests