Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring of generated nomad API does not work #21

Closed
ThomasObenaus opened this issue Mar 10, 2019 · 1 comment
Closed

Vendoring of generated nomad API does not work #21

ThomasObenaus opened this issue Mar 10, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Projects

Comments

@ThomasObenaus
Copy link
Owner

In the current configuration a dep ensure will lead to build errors due to incompatibility between the generated nomad API code and the code-generator used for this.

Due to that the vendoring folder had to be checked in.

@ThomasObenaus ThomasObenaus added the bug Something isn't working label Mar 10, 2019
@ThomasObenaus ThomasObenaus added this to Backlog in Sokar Mar 24, 2019
@ThomasObenaus ThomasObenaus moved this from Backlog to Released in Sokar Mar 24, 2019
@ThomasObenaus ThomasObenaus removed this from Released in Sokar Mar 24, 2019
@ThomasObenaus ThomasObenaus added this to In Progress in Sokar Apr 22, 2019
@ThomasObenaus ThomasObenaus self-assigned this Apr 22, 2019
@ThomasObenaus
Copy link
Owner Author

Just found out that nomad builds with this revision of github.com/ugorji/go.

Thus I pinned it to this one in the toml file:

# Fixed to revision c88ee250d0221a57af388746f5cf03768c21d6e2 because of build issues inside github.com/hashicorp/nomad
[[override]]
  name = "github.com/ugorji/go"
  revision = "c88ee250d0221a57af388746f5cf03768c21d6e2"

@ThomasObenaus ThomasObenaus moved this from In Progress to Done in Sokar Apr 22, 2019
@ThomasObenaus ThomasObenaus moved this from Done to Released in Sokar Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Sokar
  
Released
Development

No branches or pull requests

1 participant