Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatly navbar styles #1088

Closed
cpsievert opened this issue Apr 1, 2021 · 3 comments
Closed

Flatly navbar styles #1088

cpsievert opened this issue Apr 1, 2021 · 3 comments

Comments

@cpsievert
Copy link
Contributor

cpsievert commented Apr 1, 2021

In BS3 -> BS4, the "active link" selector changed from li.active > a to .nav-item > .nav-link.active, which means this CSS no longer works with BS4 or BS5

.bg-primary {
.navbar-nav .active > .nav-link {
color: $success !important;
}
}
.bg-dark {
&.navbar-dark .navbar-nav {
.nav-link:focus,
.nav-link:hover,
.active > .nav-link {
color: $primary !important;
}
}
}

@thomaspark
Copy link
Owner

Thanks for the bug report @cpsievert! We'll get that fixed up.

@cpsievert
Copy link
Contributor Author

Great thanks! Also, just FYI, I've made quite a few fixes to a handful of themes to make them a bit more themeable via Bootstrap Sass variables. See all the patch files that start with 006-bootswatch-* here https://github.com/rstudio/bslib/tree/master/tools/patches

Let me know if you'd be interested in some PRs and I can send some your way. BTW, I work for RStudio and we're very appreciative (and sponsor) of your work!

@thomaspark
Copy link
Owner

Just pushed a fix for v4. I'll take a look at v5 as well.

Awesome! I'd welcome any PRs to fix whatever issues you've come across

By the way, my colleague and good friend, who uses Shiny as a central part of their work, just tipped me off recently that you're supported Bootswatch themes. We're big fans. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants