New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hitaar: new theme #225
hitaar: new theme #225
Conversation
A night mode view of Flatly.
Hey @jenil27, this is pretty close. I like that it's essentially a re-skin of Flatly, keeping most of the components consistent. The background color is a nice choice too. Some comments:
|
Here is a revision. Thanks for your inputs @thomaspark, and I agree to your comments but I feel that the primary color should be previous green as the comes out really well on the background. The gray-green-white looks very appealing. Here is what I have got: |
What say @thomaspark? |
Hey @jenil27, it's looking really good. Nice choice for the primary color. Some suggestions for tweaks:
|
There you go @thomaspark how's this now? |
// Hitaar 3.1.1 | ||
// Bootswatch | ||
// ----------------------------------------------------- | ||
@import url(http://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this protocol relative:
@import url("//fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600");
Looks nearly there! Left some inline comments about final tweaks for you. The preview page was recently updated. You can update it in this patch if you want, but it's easy enough to update later too. What do you think of calling this theme "Darkly" to play off "Flatly"? The tagline could be "Flatly in night mode". |
Discussed at thomaspark#225
Ya, looks good to go now. I have made changes where ever it was needed and committed it for your review. Like I told you in the first comment I insist this theme be called 'Hitaar' and a subline can be anything you choose to keep. |
I missed that comment after the long screenshot. What does "Hitaar" mean? My reason for wanting to change it is that "Hitaar" is not evocative of the theme's style. This theme is a dark clone of Flatly and the name should convey to that, which Darkly does. |
My reason was to go with something meaningless, and this is surely related to Flatly, but I think the theme speaks for itself about 'dark + flatly' so lets not make is very straightforward and name it 'Darkly'. |
It's straightforward to you and me, but not as much to people evaluating a dozen themes or scanning a list of names. I feel strongly that instead of something meaningless, the name should communicate its style for this reason. Especially in this case where it's a skin of another theme. With that said, I can appreciate that it has a personal meaning to you and you were upfront about it. If you don't want it to be included for this reason, I'll respect that. |
For the people evaluating themes, we have a nice sub title given to it. Let's just stick to Hitaar and see for once how a meaningless name which is accompanied by some good work turns out to be. I want this theme to create its own identity rather than people reading it as 'Darkly - the dark clone of Flatly'. |
That's exactly it though, this theme is a dark clone of Flatly and has been conceptualized as that from the start. A random name might be ok for a brand new theme from scratch, but this one should reflect that it's a re-skin of Flatly. |
Okay. I'll create a PR with a rename then. |
Discussed at thomaspark#225
Hello @thomaspark,
I am totally heartfelt and joyous with the success of Flatly and also see that people are requesting for a version of Flatly; so here I am with a quick, to-start-with and a decent version of Hitaar: A night-mode view of Flatly. This is totally keeping in mind #191 and #224.
Here is a glimpse:
Feedback from you is most welcome. I insist on the name 'Hitaar' although I think we can work something out for a sub line.
Best from India,
Jenil