Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hitaar: new theme #225

Closed
wants to merge 2 commits into from
Closed

hitaar: new theme #225

wants to merge 2 commits into from

Conversation

jenil
Copy link
Contributor

@jenil jenil commented Feb 27, 2014

Hello @thomaspark,

I am totally heartfelt and joyous with the success of Flatly and also see that people are requesting for a version of Flatly; so here I am with a quick, to-start-with and a decent version of Hitaar: A night-mode view of Flatly. This is totally keeping in mind #191 and #224.

Here is a glimpse:
untitled

Feedback from you is most welcome. I insist on the name 'Hitaar' although I think we can work something out for a sub line.

Best from India,
Jenil

A night mode view of Flatly.
@thomaspark
Copy link
Owner

Hey @jenil27, this is pretty close. I like that it's essentially a re-skin of Flatly, keeping most of the components consistent. The background color is a nice choice too.

Some comments:

  • We should settle on one shade of green and use it for success in both this theme and Flatly. I'm open to a change. A comparison of them for both themes would be helpful.
  • White is too high contrast for the default button, but still handy to include. How about we set white to info, blue to primary, and a gray to default?
  • Let's go with green and light blue navbars instead of white.
  • How about a white background with transparent border for default inputs? Flat should avoid borders where possible.
  • The link color is really subtle. How does it look with blue or green?
  • For list groups and panels, a light gray background would differentiate it from both inputs and wells.

@jenil
Copy link
Contributor Author

jenil commented Mar 2, 2014

Here is a revision.

Thanks for your inputs @thomaspark, and I agree to your comments but I feel that the primary color should be previous green as the comes out really well on the background. The gray-green-white looks very appealing.

Here is what I have got:

png

@jenil
Copy link
Contributor Author

jenil commented Mar 11, 2014

What say @thomaspark?

@thomaspark
Copy link
Owner

Hey @jenil27, it's looking really good. Nice choice for the primary color.

Some suggestions for tweaks:

  • Can we try the nav search box as white background with no border?
  • The borders on the input states are playing weird tricks on my eyes because the contrast with the background is so low. Can you remove the borders so only the warning/error/success labels are colored?
  • The input addons need to be styled to fit with the rest of the theme. Perhaps a dark gray background with no border.
  • For pagination, can we switch the disabled and active background colors, so the active has high contrast with the background? Also would like to see disabled with white text.
  • How about darkening the border color of the list groups and default panels a touch?

@jenil
Copy link
Contributor Author

jenil commented Mar 13, 2014

There you go @thomaspark how's this now?

png

// Hitaar 3.1.1
// Bootswatch
// -----------------------------------------------------
@import url(http://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this protocol relative:

@import url("//fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600");

@thomaspark
Copy link
Owner

Looks nearly there! Left some inline comments about final tweaks for you.

The preview page was recently updated. You can update it in this patch if you want, but it's easy enough to update later too.

What do you think of calling this theme "Darkly" to play off "Flatly"? The tagline could be "Flatly in night mode".

@jenil
Copy link
Contributor Author

jenil commented Mar 14, 2014

Ya, looks good to go now. I have made changes where ever it was needed and committed it for your review.

Like I told you in the first comment I insist this theme be called 'Hitaar' and a subline can be anything you choose to keep.

@thomaspark
Copy link
Owner

I missed that comment after the long screenshot. What does "Hitaar" mean?

My reason for wanting to change it is that "Hitaar" is not evocative of the theme's style. This theme is a dark clone of Flatly and the name should convey to that, which Darkly does.

@jenil
Copy link
Contributor Author

jenil commented Mar 14, 2014

My reason was to go with something meaningless, and this is surely related to Flatly, but I think the theme speaks for itself about 'dark + flatly' so lets not make is very straightforward and name it 'Darkly'.
& 'Hitaar' is something very personal that's why I insisted.

@thomaspark
Copy link
Owner

It's straightforward to you and me, but not as much to people evaluating a dozen themes or scanning a list of names. I feel strongly that instead of something meaningless, the name should communicate its style for this reason. Especially in this case where it's a skin of another theme.

With that said, I can appreciate that it has a personal meaning to you and you were upfront about it. If you don't want it to be included for this reason, I'll respect that.

@jenil
Copy link
Contributor Author

jenil commented Mar 15, 2014

For the people evaluating themes, we have a nice sub title given to it. Let's just stick to Hitaar and see for once how a meaningless name which is accompanied by some good work turns out to be. I want this theme to create its own identity rather than people reading it as 'Darkly - the dark clone of Flatly'.
I hope you get the point. Thanks Thomas ;-)

@thomaspark
Copy link
Owner

That's exactly it though, this theme is a dark clone of Flatly and has been conceptualized as that from the start. A random name might be ok for a brand new theme from scratch, but this one should reflect that it's a re-skin of Flatly.

@jenil
Copy link
Contributor Author

jenil commented Mar 15, 2014

Okay. I'll create a PR with a rename then.

@jenil jenil closed this Mar 15, 2014
jenil added a commit to jenil/bootswatch that referenced this pull request Mar 16, 2014
@jenil jenil mentioned this pull request Mar 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants