Improve readability and add comments. #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.5_update #138 +/- ##
===============================================
+ Coverage 98.27% 98.32% +0.05%
===============================================
Files 15 15
Lines 1332 1372 +40
===============================================
+ Hits 1309 1349 +40
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thomaspinder
reviewed
Nov 6, 2022
Comment on lines
+209
to
+210
| mean_function = self.mean_function | ||
| kernel = self.kernel |
There was a problem hiding this comment.
I don't see the advantage of this? It's only going to make stepping back through the code for new users harder.
thomaspinder
reviewed
Nov 6, 2022
| @@ -31,11 +31,12 @@ class AbstractMeanFunction: | |||
| name: Optional[str] = "Mean function" | |||
|
|
|||
| @abc.abstractmethod | |||
| def __call__(self, x: Float[Array, "N D"]) -> Float[Array, "N Q"]: | |||
| def __call__(self, x: Float[Array, "N D"], params: Dict) -> Float[Array, "N Q"]: | |||
There was a problem hiding this comment.
Where we not putting params as the first argument?
thomaspinder
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor addition of comments and code readability improvements [e.g., replacing long attributes such as
self.prior.kernel(...)withkernel = self.prior.kernelthenkernel(...)]. Most major changes are to the progress bar.