Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move params to the first slot of each function, class, etc. #139

Merged
merged 2 commits into from Nov 7, 2022

Conversation

daniel-dodd
Copy link
Member

This PR moves the params argument to the first slot of each function, to match the convention of Haiku and Flax.

Also, cleans up some of the tests, add typing, for readability and adds testing of abstract classes. Some test files e.g. 'test_gps.py` need cleaning up, in future.

  • Bugfix
  • Feature
  • [ X] Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Move params to the first slot of each function, class, etc.
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #139 (afa13cf) into v0.5_update (9ee096a) will increase coverage by 0.00%.
The diff coverage is 98.14%.

@@             Coverage Diff              @@
##           v0.5_update     #139   +/-   ##
============================================
  Coverage        98.32%   98.32%           
============================================
  Files               15       15           
  Lines             1372     1377    +5     
============================================
+ Hits              1349     1354    +5     
  Misses              23       23           
Flag Coverage Δ
unittests 98.32% <98.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gpjax/kernels.py 95.08% <84.61%> (ø)
gpjax/gps.py 100.00% <100.00%> (ø)
gpjax/likelihoods.py 100.00% <100.00%> (ø)
gpjax/mean_functions.py 100.00% <100.00%> (ø)
gpjax/variational_families.py 100.00% <100.00%> (ø)
gpjax/variational_inference.py 97.77% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thomaspinder thomaspinder merged commit 97683d1 into v0.5_update Nov 7, 2022
@thomaspinder thomaspinder deleted the params_to_first_slot branch November 7, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants