Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the field PollInterval in the configuration #138

Closed
thomaspoignant opened this issue May 21, 2021 · 0 comments · Fixed by #140
Closed

Remove the field PollInterval in the configuration #138

thomaspoignant opened this issue May 21, 2021 · 0 comments · Fixed by #140
Assignees
@thomaspoignant
Labels
change This is a change in the code that should not affect the users good first issue Good for newcomers
Projects
Roadmap
Milestone
1.0.0

Comments

@thomaspoignant
Copy link
Owner

Motivation

In the PR #137 we have deprecated the field PollInterval.

Requirements

Before bumping the version to the1.0.0 we should remove this field from the Config struct.
@thomaspoignant thomaspoignant added good first issue Good for newcomers change This is a change in the code that should not affect the users before 1.0.0 labels May 21, 2021
@GoGstickGo GoGstickGo mentioned this issue May 22, 2021
Merged
7 tasks
@thomaspoignant thomaspoignant self-assigned this May 22, 2021
@thomaspoignant thomaspoignant added this to To do in Roadmap via automation May 23, 2021
@thomaspoignant thomaspoignant moved this from To do to In progress in Roadmap May 23, 2021
@thomaspoignant thomaspoignant moved this from In progress to 1.0.0 in Roadmap May 23, 2021
@thomaspoignant thomaspoignant added this to the 1.0.0 milestone May 27, 2021
Roadmap automation moved this from awaiting v1.0.0 to be merged to Done Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaspoignant thomaspoignant

Labels
change This is a change in the code that should not affect the users good first issue Good for newcomers
Projects
No open projects
Roadmap
Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

chore: rm PollInterval field GoGstickGo/go-feature-flag
1 participant
@thomaspoignant