Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(change) Replace log on variation by a log data exporter #90

Closed
thomaspoignant opened this issue Apr 12, 2021 · 0 comments · Fixed by #94
Closed

(change) Replace log on variation by a log data exporter #90

thomaspoignant opened this issue Apr 12, 2021 · 0 comments · Fixed by #94
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers p1 High priority

Comments

@thomaspoignant
Copy link
Owner

thomaspoignant commented Apr 12, 2021

Motivation

Currently, we are logging all the variations if a logger is provided.
Since this is not necessarily needed, we want to replace this with a Log exporter.

Requirements

A DataExporter that can Log with the same format as the one we have in the log.

By default we should have the same log format:

fflog.Printf(g.config.Logger, "[%v] user=\"%s\", flag=\"%s\", value=\"%v\"",

@thomaspoignant thomaspoignant added enhancement New feature or request good first issue Good for newcomers labels Apr 12, 2021
@thomaspoignant thomaspoignant added the p1 High priority label Apr 13, 2021
@thomaspoignant thomaspoignant self-assigned this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers p1 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant