New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unnecessary ? in url #222
Conversation
}.getOrElse("?") + getQueryString("with-descendants").map { | ||
val linkBase = cmWellBase + normalizedPath + "?op=search" + getQueryString("format").map { | ||
"&format=" + _ | ||
}.getOrElse("") + getQueryString("with-descendants").map { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Option.fold(ifEmpty)(elem => ...)
instead of Option.map(elem => ...).getOrElse(ifEmpty)
.
It performs a bit better and saves a few LOCs ;)
Modified code according to the changes requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Removing unecesssary ? in url * Removing unecesssary ? in url-WIP * Modifying length variable to lengthParam
* Removing unecesssary ? in url * Removing unecesssary ? in url-WIP * Modifying length variable to lengthParam
* Removing unecesssary ? in url * Removing unecesssary ? in url-WIP * Modifying length variable to lengthParam
No description provided.