Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#266 - length in qstream + boyscouting #285

Merged
merged 2 commits into from Nov 12, 2017

Conversation

hochgi
Copy link
Contributor

@hochgi hochgi commented Nov 12, 2017

No description provided.

Copy link
Contributor

@bryaakov bryaakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that def->val inline comment. besides that - LGTM

@@ -106,9 +106,11 @@ object Streams extends LazyLogging {
.mapAsyncUnordered(parallelism)(str => crudServiceFS.getInfotonByUuidAsync(str.uuid, nbg))
.collect{ case FullBox(i) => i}

def searchThinResultsToFatInfotons(nbg: Boolean, crudServiceFS: CRUDServiceFS): Flow[SearchThinResults,Infoton,NotUsed] = Flow[SearchThinResults]
def searchThinResultsFlattened: Flow[SearchThinResults,SearchThinResult,NotUsed] = Flow[SearchThinResults]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not val?

Copy link
Contributor

@bryaakov bryaakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hochgi hochgi merged commit 11eea67 into CM-Well:master Nov 12, 2017
e-orz pushed a commit to e-orz/CM-Well that referenced this pull request Feb 6, 2021
e-orz pushed a commit to e-orz/CM-Well that referenced this pull request Feb 6, 2021
e-orz pushed a commit to e-orz/CM-Well that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants