Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pip install? #8

Open
eugene-yang opened this issue Apr 16, 2024 · 5 comments
Open

Enable pip install? #8

eugene-yang opened this issue Apr 16, 2024 · 5 comments

Comments

@eugene-yang
Copy link

I'm wondering are you planning to add a setup.py to allow pip install?
I could draft one if you want :)

@andrewyates
Copy link

This would be nice! I'm happy to help test/draft it.

@eugene-yang
Copy link
Author

I'm not too familiar with Hydra, but is there a way to reference a yaml file outside of the package directory?
If we want to make this a package, not requiring people to modify the content of the package when extending to other models/experiments would be a better workflow.

@andrewyates
Copy link

I think you can use --config-dir <dir> to add an additional directory to the search path.

@thongnt99
Copy link
Owner

would it be more convenient to provide method to train without yaml file config?

@eugene-yang
Copy link
Author

I would say maybe... depends on what use cases you imagine people would be adapting this framework to.

The current setup makes it very easy to replicate experiments and adapt the code to new data, but more complicated to modify the code or inherit the classes.
The latter is making this framework more like a toolkit (e.g. huggingface transformers).
I certainly like to use it like a toolkit but it really depends on where you imagine this repository is heading to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants