Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the purpose of having a separate FlushGuard? #29

Open
PoignardAzur opened this issue Jun 10, 2024 · 0 comments
Open

What's the purpose of having a separate FlushGuard? #29

PoignardAzur opened this issue Jun 10, 2024 · 0 comments

Comments

@PoignardAzur
Copy link

Having ChromeLayerBuilder return both a layer and a guard object is inconvenient. It means that would otherwise be encapsulated code creating a subscriber with a bunch of layers now needs to return that guard to the caller, even though the caller doesn't want to know anything about the tracing implementation. (Or mem::forget the guard.)

Is there any reason the guard couldn't be stored in the ChomeLayer directly? If so, that reason should probably be included in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant