Add flock support #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tests for is_executable michael-donat#21
1.1.x symlinks (fixes michael-donat#20)
Fixed behaviour of rename function closes michael-donat#22
1 similar comment
mathroc
force-pushed
the
feature/flock
branch
from
e5c9207
to
dfe6ec9
Compare
|
Looks good, thanks. @milesj can you pull and run your failing tests against this PR? |
michael-donat
force-pushed
the
1.1.x
branch
from
d0feda9
to
caa4609
Compare
Merged
|
Will close this one, new one against 1.2.x has been raised here #33 |
|
I kind of broke all my tests but when I get around to it, I'll report any issues that popup. Cheers for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for file locking with
flockshould resolve #24
note: blocking lock is not supported but I'm not sure it makes sense anyway since only the current thread can access files in the VirtualFileSystem